Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit no expectation annotation #14231

Merged
merged 17 commits into from Jul 15, 2019

Conversation

@MathiasReker
Copy link
Contributor

commented Jun 16, 2019

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? TE
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? /

This change is Reviewable

@MathiasReker MathiasReker requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 16, 2019

@PierreRambaud
Copy link
Contributor

left a comment

See comments

MathiasReker added some commits Jul 12, 2019

@MathiasReker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

Fixed.

@PierreRambaud
Copy link
Contributor

left a comment

Forget little things :)

MathiasReker added some commits Jul 12, 2019

@MathiasReker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

Fixed

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

@PierreRambaud PierreRambaud merged commit 335d3f6 into PrestaShop:develop Jul 15, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

Tests are ok, Thanks @MathiasReker

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jul 15, 2019

@PierreRambaud PierreRambaud changed the title php unit no expectation annotation PHPUnit no expectation annotation Jul 15, 2019

mbadrani added a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.