Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manufacturers grid logo to not depend from shop context #14307

Merged
merged 2 commits into from Jul 18, 2019

Conversation

@zuk3975
Copy link
Contributor

commented Jun 20, 2019

Questions Answers
Branch? develop
Description? Changed source path of list logo image (this image is still taken from img/tmp, however now it doesn't depend from shop id). Example of previously taken image path: img/tmp/manufacturer_1_2.jpg (first number stands for manufacturerId, second was the shopId), changed to: img/tmp/manufacturer_1.jpg (only the id). This Pr intends only fixing the bug. The code should be optimized in following versions by joining some common image parsing/uploading methods.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? Changed cached image name which is used to render image in grid, but it shouldn't be a problem.
Fixed ticket? #14299
How to test? Overall manufacturers page shouldn't change, images should be rendered as before. Some behavior regarding multishop should be fixed. Refer the issue #14299 for more info.

This change is Reviewable

@zuk3975 zuk3975 requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 20, 2019

@zuk3975

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Could someone please rerun travis? 🙏 It doesn't look like PR has anything to do with its failing.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

@zuk3975 In progress! 🤞

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jun 24, 2019

@sarahdib sarahdib added this to the 1.7.6.0 milestone Jun 24, 2019

@matks matks added the migration label Jun 24, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@zuk3975 Can you target develop ?

@matks matks removed the QA ✔️ label Jun 25, 2019

@zuk3975 zuk3975 changed the base branch from 1.7.6.x to develop Jun 25, 2019

@prestonBot prestonBot added the develop label Jun 25, 2019

@marionf marionf removed the 1.7.6.x label Jun 26, 2019

@PierreRambaud PierreRambaud modified the milestones: 1.7.6.0, 1.7.7.0 Jul 1, 2019

@matks matks added the waiting for QA label Jul 3, 2019

@sarahdib sarahdib self-assigned this Jul 15, 2019

@PierreRambaud PierreRambaud merged commit 8694638 into PrestaShop:develop Jul 18, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Thanks @zuk3975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.