Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing fields validation in tax create/edit handlers #14310

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@zuk3975
Copy link
Contributor

commented Jun 20, 2019

Questions Answers
Branch? develop
Description? Tax handlers where missing fields validation. This PR adds validation to create and edit tax handlers.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? No visible changes, because currently the tax form is taking care of validation before getting to handlers.

This change is Reviewable

@zuk3975 zuk3975 requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 20, 2019

@matks matks added the migration label Jun 24, 2019

@zuk3975 zuk3975 changed the base branch from 1.7.6.x to develop Jun 25, 2019

@prestonBot prestonBot added the develop label Jun 25, 2019

@matks matks added waiting for QA and removed 1.7.6.x labels Jul 2, 2019

@matks matks added this to the 1.7.7.0 milestone Jul 2, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 3, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Thank you @zuk3975

@matks matks merged commit 8d3e985 into PrestaShop:develop Jul 3, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.