Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicated block name #14385

Merged
merged 1 commit into from Jun 28, 2019

Conversation

@aleksiuno
Copy link

commented Jun 26, 2019

Questions Answers
Branch? develop
Description? The duplicated block name was renamed. You can find duplicated block links above: https://github.com/PrestaShop/PrestaShop/blob/develop/themes/classic/templates/checkout/checkout.tpl#L65
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? You can try to override new blocks.

This change is Reviewable

Darius Aleksiunas

@aleksiuno aleksiuno requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 26, 2019

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

Hello @aleksiuno!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud
Copy link
Contributor

left a comment

Nice catch 👍

@matks

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Does not need QA I think 👍

@matks

matks approved these changes Jun 28, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Thanks @aleksiuno

@matks matks added this to the 1.7.7.0 milestone Jun 28, 2019

@matks matks merged commit 4846d0e into PrestaShop:develop Jun 28, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.