Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong way to retrieve CLDR information #14400

Merged
merged 3 commits into from Jun 28, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Jun 27, 2019

Questions Answers
Branch? 1.7.6.x
Description? Because pattern can contains the negative and the positive pattern (¤ #,##0.00;¤ -#,##0.00), min / max fractions digits aren't count properly, same for group size and decimals.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14392
How to test? Follow ticket instruction

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 27, 2019

@tomlev

tomlev approved these changes Jun 27, 2019

@matks matks added this to the 1.7.6.0 milestone Jun 27, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jun 28, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Thank you @PierreRambaud

@matks matks merged commit c3b9a85 into PrestaShop:1.7.6.x Jun 28, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.