Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grid calendar #14401

Merged
merged 3 commits into from Jun 28, 2019

Conversation

@jolelievre
Copy link
Contributor

commented Jun 27, 2019

Questions Answers
Branch? 1.7.6.x
Description? Remove special case for customers, instead fix overflow on tables and fix calendar cropping properly
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14301 and #14275
How to test? Test customer page on low resolution, the scrollbar is now on the table not the whole page (bootstrap default behavior). Test the calendar, it must display correctly above the grid (even after a resize).

This change is Reviewable

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 27, 2019

@jolelievre jolelievre force-pushed the jolelievre:fix-grid-calendar branch from d0a60f9 to d4250fc Jun 27, 2019

@matks

matks approved these changes Jun 28, 2019

@matks matks added this to the 1.7.6.0 milestone Jun 28, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jun 28, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Thank you @jolelievre

@matks matks merged commit 48338b0 into PrestaShop:1.7.6.x Jun 28, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jolelievre jolelievre deleted the jolelievre:fix-grid-calendar branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.