Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate aria-label in modal close button #14437

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@davidglezz
Copy link
Contributor

commented Jul 1, 2019

Questions Answers
Branch? develop
Description? aria-label="Close" to aria-label="{l s='Close' d='Shop.Theme.Global'}"
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

@davidglezz davidglezz requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 1, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Nice catch!

@davidglezz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

I think the tests have failed because an error that is not related to the modifications:

(#blockcart-modal) still not visible after 2500ms

maybe it was an ajax timeout when adding a product to the cart

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Yes, it's a random CI issue (#14384)

@sarahdib

This comment has been minimized.

Copy link

commented Jul 4, 2019

Hello @davidglezz

Thank you for this PR.

Can you provide me the tests steps ?

Thank you :)

@davidglezz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

I simply translate some labels.
Before the patch: the labels always "close" in English
After the patch: label in the correct language.

To test it use a screenreader or check the source code corresponding to the close button of involved modal-dialogs, for example, in "quick view" or "product added to cart popup".

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 9, 2019

@matks matks added this to the 1.7.7.0 milestone Jul 9, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Thank you @davidglezz

@matks matks merged commit 45abf13 into PrestaShop:develop Jul 9, 2019

2 of 3 checks passed

code-review/reviewable 7 files left
Details
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.