Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the factory with number and price specifications #14438

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Jul 1, 2019

Questions Answers
Branch? 1.7.6.x
Description? Cldr\Factory tests. We'll improve tests each time we'll find a new bug :)
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Travis must be green.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 1, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jul 1, 2019

@Quetzacoalt91
Copy link
Member

left a comment

Related to #14400 I guess?

@Quetzacoalt91 Quetzacoalt91 merged commit 84a83e2 into PrestaShop:1.7.6.x Jul 2, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.