Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist filters for the Logs Page #14450

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@Progi1984
Copy link
Contributor

commented Jul 2, 2019

Questions Answers
Branch? develop
Description? Filters in logs page are now whitelisted
Type? bug fix
Category? BO
BC breaks? No
Deprecations? No
Fixed ticket? Fixes #12835
How to test? * Go to BO Logs page, URL should be something like http://localhost/admin-dev/index.php/configure/advanced/logs/
* Perform a filter search, for example filter logs on the word "Back", the URL should be something like http://localhost/admin-dev/index.php/configure/advanced/logs/?filters%5Bmessage%5D=Back&_token=[your token]
* Modify this URL and replace "message" by "mossage"
* Refresh with the modified URL
* The filter will not filtered because it is not in the white list

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 2, 2019

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

Hello @Progi1984!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@matks

matks approved these changes Jul 2, 2019

@matks matks added the waiting for QA label Jul 2, 2019

@matks matks added this to the 1.7.7.0 milestone Jul 2, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 3, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Thank you @Progi1984

@matks matks merged commit a972276 into PrestaShop:develop Jul 3, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Progi1984 Progi1984 deleted the Progi1984:issue12835 branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.