Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to buy a product without stock when other combinations have stock and unavailable product attributes are not displayed #14452

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@Progi1984
Copy link
Contributor

commented Jul 2, 2019

Questions Answers
Branch? develop
Description? Permit to buy a product without stock when other combination have stock and unavailable product attributes are not displayed
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9667
How to test? * Create a product with combinations. Put stock in some combination but not in all.
* Allow to buy products out of stock.
* Disable the option "Display unavailable product attributes on the product page" in Product Settings page
* In FO, combinations out of stock can be selected

@colinegin @TristanLDD I think that correct the bug #9667 but the behavior is not perfect : when you deny to buy products out of stock, the combination (which doesn't have stock) reset


This change is Reviewable

Permit to buy a product without stock when other combination have sto…
…ck and unavailable product attributes are not displayed

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 2, 2019

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

Hello @Progi1984!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@matks

matks approved these changes Jul 2, 2019

@marionf

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

@Progi1984

@colinegin @TristanLDD I think that correct the bug #9667 but the behavior is not perfect : when you deny to buy products out of stock, the combination (which doesn't have stock) reset

Yes, we have already an issue for that: #9948
But it's another issue, not related to this PR :)

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Thank you @Progi1984

@matks matks merged commit 2e0fa72 into PrestaShop:develop Jul 3, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Progi1984 Progi1984 deleted the Progi1984:issue9667 branch Jul 3, 2019

@eternoendless eternoendless changed the title Permit to buy a product without stock when other combination have stock and unavailable product attributes are not displayed Allow to buy a product without stock when other combinations have stock and unavailable product attributes are not displayed Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.