Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore index.php files in Doctrine entities scanning #14460

Merged

Conversation

@jolelievre
Copy link
Contributor

commented Jul 3, 2019

Questions Answers
Branch? 1.7.6.x
Description? Change annotation driver settings so that it ignores index.php files present in Entities folder (the file contains an exit which stopped all doctrine commands execution)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? Install productcomments module, try to run doctrine:mapping:info or doctrine:schema:update command without this PR nothing happens, with the PR it works correctly and the module's entities are listed

This change is Reviewable

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 3, 2019

@jolelievre jolelievre changed the title Change annotation driver settings so that it ignores index.php files … Ignore index.php files in Doctrine entities scanning Jul 3, 2019

@jolelievre jolelievre force-pushed the jolelievre:ignore-index-in-entites branch from 1277b31 to 8123f2a Jul 3, 2019

@matks matks added the waiting for QA label Jul 3, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 3, 2019

@eternoendless

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thank you @jolelievre

@eternoendless eternoendless merged commit 2fad71a into PrestaShop:1.7.6.x Jul 3, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.6.0 milestone Jul 3, 2019

@jolelievre jolelievre deleted the jolelievre:ignore-index-in-entites branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.