Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving of selected BO language #14466

Merged
merged 3 commits into from Jul 17, 2019

Conversation

@rokaszygmantas
Copy link
Contributor

commented Jul 3, 2019

Questions Answers
Branch? develop
Description? There is a setting, which enables saving of selected language in BO forms. When enabled, whenever you choose a language in translatable field, the language will be memorized and preselected in all forms. This feature was not working in migrated pages.
Type? bug fix
Category? BO
BC breaks? No
Deprecations? No
Fixed ticket? No
How to test? Steps below.

Steps to test:

  1. Enable Memorize the language used in Admin panel forms setting at /admin-dev/index.php/configure/advanced/employees/
  2. Go to a migrated form that has translatable inputs, e.g. /admin-dev/index.php/configure/shop/product-preferences/ or any other.
  3. Change language on translatable input.
  4. Refresh the page - language should remain the same as have selected before.

This change is Reviewable

@rokaszygmantas rokaszygmantas requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 3, 2019

@matks matks added the waiting for QA label Jul 3, 2019

@matks matks added this to the 1.7.7.0 milestone Jul 3, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Nice catch !

@sarahdib

This comment has been minimized.

Copy link

commented Jul 4, 2019

Hello @rokaszygmantas :)

I found a little bug with this PR you can check the video here
https://drive.google.com/file/d/13HqbkZZGVToVypyooP0x8v1gThvY8B7J/view

Thank you

@rokaszygmantas

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Hello @sarahdib,

The issue that you've found should now be fixed. 🙂

Thanks!

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 16, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Thank you @rokaszygmantas

@matks matks merged commit be7f337 into PrestaShop:develop Jul 17, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mbadrani added a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019

Merge pull request PrestaShop#14466 from rokaszygmantas/restore_save_…
…employee_lang

Fix saving of selected BO language

@rokaszygmantas rokaszygmantas deleted the rokaszygmantas:restore_save_employee_lang branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.