Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted e2e tests #14467

Merged

Conversation

@PierreRambaud
Copy link
Contributor

commented Jul 3, 2019

Questions Answers
Branch? 1.7.6.x
Description? These tests are created based on existing issue. Because until it's fixed, they are falling in failure.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? Waiting for nightly tests.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 3, 2019

@@ -157,11 +108,7 @@ scenario('Update quantity of a product', () => {
.then(() => client.checkTextValue(Stock.success_hidden_panel,'Stock successfully updated', 'contain'));
});
for (let i = 1; i <= 3; i++) {
if (i === 1) {

This comment has been minimized.

Copy link
@Quetzacoalt91

Quetzacoalt91 Jul 3, 2019

Member

don't you want to continue on the first row?

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 3, 2019

Author Contributor

It continues, but only the first one was failing ^^

@PierreRambaud PierreRambaud added the TE label Jul 3, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jul 3, 2019

@PierreRambaud PierreRambaud merged commit 56dea81 into PrestaShop:1.7.6.x Jul 3, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:remove-unwanted-e2E-tests branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.