Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Puppeteer to check links on FO and BO #14508

Merged
merged 29 commits into from Jul 11, 2019

Conversation

@mbadrani
Copy link
Contributor

commented Jul 5, 2019

Questions Answers
Branch? develop
Description? This is our new E2E test framework including Puppeteer
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Please follow the steps described into the Readme file.

This change is Reviewable

@mbadrani mbadrani added this to the 1.7.7.0 milestone Jul 5, 2019

@mbadrani mbadrani requested review from eternoendless and matks Jul 5, 2019

@mbadrani mbadrani requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 5, 2019

@PierreRambaud PierreRambaud changed the title this is our first E2E Puppeteer based tests Integrate Puppeteer to check links on FO and BO Jul 9, 2019

@PierreRambaud PierreRambaud added the WIP label Jul 9, 2019

@boubkerbribri boubkerbribri removed the WIP label Jul 10, 2019

boubkerbribri and others added some commits Jul 10, 2019

Update README
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
Update README
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
Update README
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@mickaelandrieu
Copy link
Contributor

left a comment

Some minor comments

tests/puppeteer/README.md Outdated Show resolved Hide resolved
tests/puppeteer/README.md Outdated Show resolved Hide resolved
tests/puppeteer/README.md Show resolved Hide resolved
tests/puppeteer/test/linkchecker.js Outdated Show resolved Hide resolved
tests/puppeteer/test/linkchecker.js Outdated Show resolved Hide resolved
tests/puppeteer/test/linkchecker.js Outdated Show resolved Hide resolved

@boubkerbribri boubkerbribri requested a review from mickaelandrieu Jul 10, 2019


cd /var/www/html
echo "\n* Install Dependencies...";
/usr/bin/composer install --no-suggest --ansi --prefer-dist --no-interaction --no-progress --quiet

This comment has been minimized.

Copy link
@Quetzacoalt91

Quetzacoalt91 Jul 10, 2019

Member

If you plan to make the shop running on production mode, you probably don't need the dev dependencies

Suggested change
/usr/bin/composer install --no-suggest --ansi --prefer-dist --no-interaction --no-progress --quiet
/usr/bin/composer install --no-suggest --ansi --prefer-dist --no-interaction --no-progress --quiet --no-dev

This comment has been minimized.

Copy link
@SimonGrn

SimonGrn Jul 10, 2019

Contributor

We will fix it on the next PR, we would love to have this one merged ASAP so we can work on our own forks like before, if possible :-D

@mbadrani mbadrani merged commit f9a8848 into PrestaShop:develop Jul 11, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mbadrani

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

Thanks everybody!

@colinegin colinegin added this to To be merged in PrestaShop 1.7.7 Jul 11, 2019

@colinegin colinegin moved this from To be merged to Done in PrestaShop 1.7.7 Jul 11, 2019

mbadrani added a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019

Merge pull request PrestaShop#14508 from mbadrani/addingE2E-puppeteer
Integrate Puppeteer to check links on FO and BO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.