Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position problem on a fresh install #14529

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Jul 8, 2019

Questions Answers
Branch? develop
Description? AddPosition must add the position in category table and updatePosition should test for negative position
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14504
How to test? Follow ticket instruction

This change is Reviewable

Fix position problem on a fresh install
- AddPosition must add the position in category table
- updatePosition should test for negative position

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 8, 2019

@matthieu-rolland
Copy link
Contributor

left a comment

LGTM

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 10, 2019

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jul 10, 2019

@PierreRambaud PierreRambaud merged commit 5781574 into PrestaShop:develop Jul 10, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/14504 branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.