Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Preview link without option for seo preview #14530

Merged
merged 2 commits into from Jul 11, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Jul 8, 2019

Questions Answers
Branch? develop
Description? Always use the getPreviewUrl with $preview set to false.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14054
How to test? Follow ticket instruction.

This change is Reviewable

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

I restart Travis as it failed randomly again.
I also opened a PR to remove the faulty random tests. #14531

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

I restart Travis as e2e test failed randomly.
Also I opened a PR to remove the bad test #14531

@matks

matks approved these changes Jul 8, 2019

@matks matks added this to the 1.7.7.0 milestone Jul 8, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 10, 2019

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Thanks for the validation @sarahdib !

@mickaelandrieu mickaelandrieu merged commit 0feed3b into PrestaShop:develop Jul 11, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/14054 branch Jul 11, 2019

mbadrani added a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019

Merge pull request PrestaShop#14530 from PierreRambaud/fix/14054
Use Preview link without  option for seo preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.