Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email display dependant on configuration from ps_contactinfo module #14539

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

commented Jul 9, 2019

Questions Answers
Branch? develop
Description? Display email address or not depending on configuration variable
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14416
How to test? see #14416

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 9, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Hello @breizoreol!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@marionf

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Behavior specified in the issue: #14416 (comment)

@jolelievre

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Oh you have to add a toggle button for these two blocks @matthieu-rolland
So it seems like you're gonna have to modify the modules directly/as well

@PierreRambaud PierreRambaud dismissed their stale review Aug 1, 2019

Original wanted behavior change

@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:feat-remove-clear-mail branch 2 times, most recently from 1b7b8b0 to d0b79e7 Aug 1, 2019
@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

So the feature request as changed, as you can see here #14416 .

I made the requested modifications.

@matthieu-rolland matthieu-rolland changed the title Improvement: remove clear email Make email display dependant on configuration from ps_contactinfo module Aug 7, 2019
@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:feat-remove-clear-mail branch from 0c1f889 to cfb3d95 Aug 21, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 21, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Aug 21, 2019
@matthieu-rolland matthieu-rolland merged commit f01b47d into PrestaShop:develop Aug 22, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.