Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Import controller to get errors for bad category import #14540

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@webmak
Copy link
Contributor

commented Jul 9, 2019

Fix bug with this issue #12998

Questions Answers
Branch? develop
Description? fix this issue #12998
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #12998.
How to test? Run wrong category import to get this erro Parent category 34 does not exist

This change is Reviewable

Update AdminImportController.php
Fix bug with this issue #12998

@webmak webmak requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 9, 2019

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Hello @webmak!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Hi!

Your pull request description seems to be incomplete or malformed:

  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@sarahdib

This comment has been minimized.

Copy link

commented Jul 17, 2019

Hello @webmak

Can you provide me the file for the test ?

Thank you :)

@webmak

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

Hello @webmak

Can you provide me the file for the test ?

Thank you :)

Hello you can read here #12998 and as I understand @khouloudbelguith reproduced so you can ask she for this file. I've fixed this bug for my client and I can't provide his file

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 17, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Thank you @webmak

@matks matks merged commit 769f9e6 into PrestaShop:develop Jul 17, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matks matks changed the title Update AdminImportController.php Update Import controller to get errors for bad category import Jul 17, 2019

@webmak

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

Thank you @webmak

Glad to help

mbadrani added a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.