Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong path of products thumbnails in back office #14543

Merged
merged 3 commits into from Jul 17, 2019

Conversation

@matthieu-rolland
Copy link
Contributor

commented Jul 9, 2019

Questions Answers
Branch? develop
Description? Fixes broken product image in backoffice > stock list page
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14374
How to test? Go in backoffice > catalogue > stocks, and see that products thumbnails are displayed correctly, also in category edition page, and in brand and manufacturer list page

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 9, 2019

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Hello @breizoreol!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@matks matks added the waiting for QA label Jul 9, 2019

@matks matks added this to the 1.7.7.0 milestone Jul 9, 2019

@matks matks added WIP and removed waiting for QA labels Jul 9, 2019

@PierreRambaud PierreRambaud changed the title fix: fix wrong path of products thumbnails in bo stock page Wrong path of products thumbnails in bo stock page Jul 9, 2019

@matthieu-rolland matthieu-rolland removed the WIP label Jul 9, 2019

@matthieu-rolland matthieu-rolland changed the title Wrong path of products thumbnails in bo stock page Wrong path of products thumbnails in back office Jul 9, 2019

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@PrestaShop/prestashop-core-developers
This PR is still waiting for approval :)

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 17, 2019

@matthieu-rolland matthieu-rolland merged commit 3249fbe into PrestaShop:develop Jul 17, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mbadrani added a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019

Merge pull request PrestaShop#14543 from matthieu-rolland/fix-stock-img
Wrong path of products thumbnails in back office
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.