Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use variable instead of recomputing #14552

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@jolelievre
Copy link
Contributor

commented Jul 9, 2019

Questions Answers
Branch? 1.7.6.x
Description? Use variable instead of recomputing file path
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? ~

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.6.0 milestone Jul 9, 2019

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 9, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

No need QA, merge when travis's green!

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Restarting Travis...

@PierreRambaud PierreRambaud merged commit eb7cded into PrestaShop:1.7.6.x Jul 9, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Thanks @jolelievre

@jolelievre jolelievre deleted the jolelievre:fix-exclude-index branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.