Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Schema ItemList for products listing & Fix Schema Product #14558

Merged
merged 4 commits into from Jul 18, 2019

Conversation

@Progi1984
Copy link
Contributor

commented Jul 9, 2019

Questions Answers
Branch? develop
Description? Implement Schema ItemList for products listing & Fix Schema Product (price, url).
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12687 & #12694
How to test? * Get the code from a listing product page (best sellers, new products, featured products, ...)
* Go to the Google Structured Data Testing Tool
* Check no errors except "All values provided for url must point to the same page."

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Jul 9, 2019

@Progi1984 Progi1984 requested a review from PierreRambaud Jul 9, 2019

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@PrestaShop/prestashop-qa Hi, in tests, the test crash on this : "no such element: Unable to locate element: {"method":"css selector","selector":".product-miniature:nth-of-type(2) a.product-thumbnail"}". In my local (with an install base), on the page "/en/3-clothes", it only works with ".product-miniature:nth-of-type(1) a.product-thumbnail"

@SimonGrn

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

Hello, not sure what test you're talking about exactly. Can you be more specific please ?
Thanks.

We don't match this problem with an error in our campaign results.

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@SimonGrn Sorry, this one tests/Selenium/helpers/checkout.js from the test named "Add product to cart as a guest": https://travis-ci.org/PrestaShop/PrestaShop/jobs/556387247#L714

@SimonGrn

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

That's weird, on a fresh install this element is perfectly catchable : there is 2 elements in the clothes section. Did your modification change the number of items in the clothes section ?

You should try to relaunch the job to see if it's just a Travis hiccup or something more serious that needs investigating.

If it still fails, we'll change the selector.

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@SimonGrn If there are two elements, nth-of-type(2) return nothing, because nth-of-type begins to 0, so the second element is nth-of-type(1). My modification doesn't change the number of products.

I retry to launch it this morning and same bug.

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@SimonGrn I say some fake news : nth-of-type begins to 1 but browser doesn't return the second

image

@SimonGrn

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

The pseudo-selector nth-of-type doesn't start at 0, it selects the nth element. So nth-of-type(2) selects the second element. You can check here.

You can see for yourself on this screenshot:
screenshot_css_selector

The problem lies somewhere else. It probably can't access the item it's looking for because it's not on the right page. Can you retrieve the screenshot somehow ?

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@SimonGrn @boubkerbribri @PierreRambaud It's good :) Travis pass :)

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Ah ! I've just noticed yesterday that google was unhappy with our rich data.

Nice contribution 👍

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 18, 2019

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 18, 2019

@PierreRambaud PierreRambaud merged commit 06af0e7 into PrestaShop:develop Jul 18, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Thanks @Progi1984

@Progi1984 Progi1984 deleted the Progi1984:issue12687 branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.