Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix many things that were supposed to be removed during build not being removed #14579

Merged
merged 2 commits into from Jul 10, 2019

Conversation

@eternoendless
Copy link
Member

commented Jul 10, 2019

Questions Answers
Branch? 1.7.6.x
Description? During build, some files are supposed to be removed. Not all of them were.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Create a build and see the files

Now being removed:

  • Things that were supposed to be removed from admin, because the folder was renamed before cleaning it up
  • Legacy tests
  • .estlintignore, .eslintrc.js, .php_cs.dist, .docker-compose.yml, .webpack, .composer-lock, .package-lock.json...

This change is Reviewable

Many things that were supposed to be removed weren't:
- Anything under admin, because the folder was renamed before cleaning it up
- Legacy tests
- .estlintignore, .eslintrc.js, .php_cs.dist, .docker-compose.yml, .webpack, .composer-lock, .package-lock.json...

@eternoendless eternoendless added this to the 1.7.6.0 milestone Jul 10, 2019

@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 10, 2019

'\.php_cs\.dist$',
'\.docker-compose\.yml$',
'tools/assets$',
'\.webpack$',

This comment has been minimized.

Copy link
@matks

matks Jul 10, 2019

Contributor

Sure about this one ?

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Jul 10, 2019

Contributor

Yes, it must be removed

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

It turns out that removing the scss directory makes some images fail to load:

{  
   "stats":{  
      "start":1562774927780,
      "end":1562775021375
   },
   "BO":{  
      "totalLinks":66,
      "totalRequests":3901,
      "passed":[  

      ],
      "failed":[  
         {  
            "page":"http://localhost/prestashop_off/admin197jt4ja1/index.php/sell/catalog/categories?_token=-y31_3bIbjdb5n64hnauN_nawxxKF_seUqqAqVKih4M",
            "URL":"http://localhost/prestashop_off/admin197jt4ja1/themes/new-theme/scss/img/helper-card/category@3x.png?1.7.6.0",
            "status":"404"
         },
         {  
            "page":"http://localhost/prestashop_off/admin197jt4ja1/index.php/sell/customers/?_token=-y31_3bIbjdb5n64hnauN_nawxxKF_seUqqAqVKih4M",
            "URL":"http://localhost/prestashop_off/admin197jt4ja1/themes/new-theme/scss/img/helper-card/customer@3x.png?1.7.6.0",
            "status":"404"
         },
         {  
            "page":"http://localhost/prestashop_off/admin197jt4ja1/index.php/improve/design/themes/?_token=-y31_3bIbjdb5n64hnauN_nawxxKF_seUqqAqVKih4M",
            "URL":"http://localhost/prestashop_off/admin197jt4ja1/themes/new-theme/scss/img/pages/themes/icon_themes.png?1.7.6.0",
            "status":"404"
         },
         {  
            "page":"http://localhost/prestashop_off/admin197jt4ja1/index.php/improve/design/themes/?_token=-y31_3bIbjdb5n64hnauN_nawxxKF_seUqqAqVKih4M",
            "URL":"http://localhost/prestashop_off/admin197jt4ja1/themes/new-theme/scss/img/pages/themes/icon_layouts.png?1.7.6.0",
            "status":"404"
         },
         {  
            "page":"http://localhost/prestashop_off/admin197jt4ja1/index.php/improve/design/cms-pages/?_token=-y31_3bIbjdb5n64hnauN_nawxxKF_seUqqAqVKih4M",
            "URL":"http://localhost/prestashop_off/admin197jt4ja1/themes/new-theme/scss/img/helper-card/content@3x.png?1.7.6.0",
            "status":"404"
         },
         {  
            "page":"http://localhost/prestashop_off/admin197jt4ja1/index.php/configure/shop/seo-urls/?_token=-y31_3bIbjdb5n64hnauN_nawxxKF_seUqqAqVKih4M",
            "URL":"http://localhost/prestashop_off/admin197jt4ja1/themes/new-theme/scss/img/helper-card/seo@3x.png?1.7.6.0",
            "status":"404"
         },
         {  
            "page":"http://localhost/prestashop_off/admin197jt4ja1/index.php/configure/advanced/employees/?_token=-y31_3bIbjdb5n64hnauN_nawxxKF_seUqqAqVKih4M",
            "URL":"http://localhost/prestashop_off/admin197jt4ja1/themes/new-theme/scss/img/helper-card/team@3x.png?1.7.6.0",
            "status":"404"
         }
      ]
   }
}

Kudos to @SimonGrn

It looks like image extraction through webpack isn't working well.

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

Merging this for the nightlies

@eternoendless eternoendless merged commit 8607b01 into PrestaShop:1.7.6.x Jul 10, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:fix-build branch Jul 10, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

@eternoendless Shall we create an issue to fix bad images loaded from scss folder ?

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.