Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First POM implementation #14593

Merged
merged 24 commits into from Jul 18, 2019

Conversation

@SimonGrn
Copy link
Contributor

commented Jul 11, 2019

Questions Answers
Branch? develop
Description? First implementation of the Page object pattern with puppeteer.
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? node_modules/mocha/bin/mocha test/smoke/main

This change is Reviewable

@SimonGrn SimonGrn requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 11, 2019

@SimonGrn SimonGrn added the WIP label Jul 11, 2019

@SimonGrn SimonGrn added this to In progress in PrestaShop 1.7.6 via automation Jul 11, 2019

@SimonGrn SimonGrn added this to the 1.7.7.0 milestone Jul 11, 2019

Show resolved Hide resolved tests/puppeteer/test/utils/helpers.js Outdated
Show resolved Hide resolved tests/puppeteer/test/utils/helpers.js Outdated

@colinegin colinegin removed this from In progress in PrestaShop 1.7.6 Jul 12, 2019

@boubkerbribri boubkerbribri added the TE label Jul 15, 2019

@SimonGrn SimonGrn removed the WIP label Jul 15, 2019

@SimonGrn SimonGrn force-pushed the SimonGrn:POM branch from 0e08e97 to 809ca68 Jul 16, 2019

@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers Jul 17, 2019

@matks

matks approved these changes Jul 18, 2019

Copy link
Contributor

left a comment

A few things to fix, that can be fixed in future PRs:

  • naming tests/puppeteer/test is not great (duplicate test word)
  • still a few global items

Maybe you can create issues not to forget them 😉?

@mbadrani mbadrani merged commit 0bdf263 into PrestaShop:develop Jul 18, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SimonGrn SimonGrn deleted the SimonGrn:POM branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.