Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use encodeURIComponent with POST data #14605

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Jul 12, 2019

Questions Answers
Branch? develop
Description? Do not use encodeURIComponent with POST data
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14604
How to test? Follow ticket instruction.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 12, 2019

@01park

This comment has been minimized.

Copy link

commented Jul 15, 2019

Solution does not 100% worked. When I change the status of the order, in my case, to shipped. The strange % comes back.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

I'm not able to reproduce even if I change the order status to shipped.
Do you clear your browser cache?

@01park

This comment has been minimized.

Copy link

commented Jul 15, 2019

yes, I have clear browser.

Im no sure if I applied the fix correctly. I copied the code from here and paste this in the old one ( delete the wrong code). Was this correct?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

I don't really know :/ Maybe you have module or anything else which alter data.

@01park

This comment has been minimized.

Copy link

commented Jul 15, 2019

no, I just have the basic PS.

Would you be able to send me the file, that needs to be replaced / updated

@PierreRambaud

This comment has been minimized.

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/14604 branch from 318d9f2 to 552b453 Jul 15, 2019

@PierreRambaud PierreRambaud changed the base branch from develop to 1.7.6.x Jul 15, 2019

@jolelievre
Copy link
Contributor

left a comment

Nice job @PierreRambaud

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 17, 2019

@sarahdib sarahdib added this to the 1.7.6.1 milestone Jul 17, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Thank you @PierreRambaud

@01park if the issue remains on your side and you find what are the conditions required to reproduce the bug, please tell us 😉 we'll fix it in another PR

In the meantime, this PR solves the issue as far as we know so it's relevant to merge it

@matks matks merged commit 643f50b into PrestaShop:1.7.6.x Jul 17, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.