Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker for puppeteer #14612

Merged

Conversation

@boubkerbribri
Copy link
Contributor

commented Jul 12, 2019

Questions Answers
Branch? develop
Description? refactoring dockerFiles and docker-compose file
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? See the readMe file to know how test with docker-compose

This change is Reviewable

@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Jul 12, 2019

@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 12, 2019

@boubkerbribri boubkerbribri changed the title Update docker in puppeteer Update docker for puppeteer Jul 12, 2019

@boubkerbribri boubkerbribri removed the WIP label Jul 15, 2019

@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers Jul 15, 2019

@PierreRambaud PierreRambaud merged commit 844ceb9 into PrestaShop:develop Jul 16, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@boubkerbribri boubkerbribri deleted the boubkerbribri:updateDockerInPuppeteer branch Jul 16, 2019

mbadrani added a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.