Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init properly the Kernel on major *manual* upgrades #14620

Conversation

@Quetzacoalt91
Copy link
Member

commented Jul 12, 2019

Questions Answers
Branch? 1.7.6.x
Description? Upgrades to PS 1.7.6 require the kernel to run. Unfornately, the migration of the settings file when upgrading from PS < 1.7 was done AFTER the checks allowing the kernel to be enabled. This PR orders the functions calls accordingly.
Type? bug fix
Category? IN
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #14591 & #14617
How to test? Follow #14591 (comment)

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 12, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Milestone must be created!

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.1 milestone Jul 12, 2019

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

Done

@PierreRambaud PierreRambaud merged commit 0ab5533 into PrestaShop:1.7.6.x Jul 24, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.