Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing shop association in Category and Manufacturer #14656

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@zuk3975
Copy link
Contributor

commented Jul 15, 2019

…egory edit handlers

Questions Answers
Branch? develop
Description? associateWithShops() method of AbstractObjectModelHandler didn't work when used before object->update(). So it caused issues, when updating shop association (nr. 1@ #13485 (comment)). This PR moves that method usage to be after update() and take effect in EditManufacturerHandler and EditCategoryHandler .
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Go to Manufacturers or Category page while having multiple shops, edit it -> change shop association. See the change is made after submit. (previously the change didn't take any effect)Screenshot from 2019-07-15 14-49-58 Screenshot from 2019-07-15 14-51-26

This change is Reviewable

@zuk3975 zuk3975 requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 15, 2019

@matks

matks approved these changes Jul 17, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 19, 2019

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 19, 2019

@PierreRambaud PierreRambaud merged commit 14b713a into PrestaShop:develop Jul 19, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Thanks @zuk3975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.