Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update precision and numeric iso code of currencies #14664

Merged

Conversation

@Quetzacoalt91
Copy link
Member

commented Jul 15, 2019

Questions Answers
Branch? 1.7.6.x
Description? Upgrading to 1.7.6.0 applies changes to the database schema to add precision and a numeric iso code, but they kept their default values. This PR loads the CLDR and sets the values.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #14608 / Fixes #14640
How to test? Upgrade to 1.7.6.1 and review your databse. Homemade currencies should not break the upgrade

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 15, 2019

@eternoendless

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

PS_PRICE_DISPLAY_PRECISION is still used in some places, I wonder if it has something to do...

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:update-currency-decimals branch from ef51529 to b3717c2 Jul 16, 2019

@Quetzacoalt91

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

PS_PRICE_DISPLAY_PRECISION is still used in some places, I wonder if it has something to do...

That's a good question. However the objective here is to have the same content in database as with a fresh installation of PrestaShop.

@eternoendless
Copy link
Member

left a comment

LGTM

@eternoendless eternoendless added this to the 1.7.6.1 milestone Jul 17, 2019

@PierreRambaud PierreRambaud merged commit 13644e7 into PrestaShop:1.7.6.x Jul 24, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@ajejebrazorf01

This comment has been minimized.

Copy link

commented Aug 7, 2019

I don't understand how to fix this issue. What are the steps to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.