Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure token is properly used in legacy context #14671

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Jul 16, 2019

Questions Answers
Branch? develop
Description? Thanks Guillaume Lictevout. Make sure token is properly working.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Play with token
wrong token: /admin-dev/index.php?controller=AdminCartRules&token=f874272f93a463c9547447241a2cf5c4
Empty token: /admin-dev/index.php?controller=AdminCartRules&token=
No token: /admin-dev/index.php?controller=AdminCartRules

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.6.1 milestone Jul 16, 2019

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 16, 2019

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/legacy-token branch from 74213bc to e00afa9 Jul 16, 2019

@PierreRambaud PierreRambaud changed the base branch from develop to 1.7.6.x Jul 16, 2019

@matthieu-rolland
Copy link
Contributor

left a comment

LGTM

@eternoendless

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

Not sure if relevant, but what about when the token is 0 or empty space?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

Not sure if relevant, but what about when the token is 0 or empty space?

The token is considered as empty.
We shouldn't allow ?token= or ?token=0

@marionf marionf added 1.7.6.x and removed develop labels Jul 30, 2019

@sarahdib sarahdib added this to In progress in PrestaShop 1.7.6 via automation Jul 30, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 30, 2019

@sarahdib sarahdib moved this from In progress to To be merged in PrestaShop 1.7.6 Jul 30, 2019

@sarahdib sarahdib removed this from To be merged in PrestaShop 1.7.6 Jul 30, 2019

@PierreRambaud PierreRambaud merged commit e8a8a1b into PrestaShop:1.7.6.x Jul 30, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/legacy-token branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.