Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Tab with symfony routes, menu now handles disabled modules #14679

Merged
merged 8 commits into from Aug 28, 2019

Conversation

@jolelievre
Copy link
Contributor

commented Jul 16, 2019

Questions Answers
Branch? develop
Description? Manage automatic tab registration with symfony tabs (even when controller is missing), the menu is now able to use this new route_name parameter to generate the urls. The enable/disable feature now hides the tabs linked to the module automatically
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11578 and #12640
How to test? You can use this branch of the ps_linklist module PrestaShop/ps_linklist#70 It uses the new automatic tab creation and symfony route, just check that after installation its tab is correctly displayed (right url)
Then you can test the enable/disable feature on this module, when the module is disabled the link in the menu disappears

This change is Reviewable

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 16, 2019
@jolelievre jolelievre added this to the 1.7.7.0 milestone Jul 16, 2019
classes/Tab.php Outdated Show resolved Hide resolved
@jolelievre jolelievre force-pushed the jolelievre:tab-with-route branch from f6aff68 to 1940fa1 Jul 18, 2019
@sarahdib sarahdib self-assigned this Aug 22, 2019
@sarahdib

This comment has been minimized.

Copy link

commented Aug 28, 2019

@jolelievre

All backoffice menu disappear after applying this PR

image

@sarahdib

This comment has been minimized.

Copy link

commented Aug 28, 2019

it's ok with a fresh install :)
Thank you @jolelievre

@PierreRambaud PierreRambaud merged commit 4e5b763 into PrestaShop:develop Aug 28, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

Thanks @jolelievre

@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@jolelievre Does it fully handles the need expressed in #12640 ? Can we close the ticket #12640 😄?

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@matks yes this PR deals with both issues, so I'm going to close the #12640

@jolelievre jolelievre deleted the jolelievre:tab-with-route branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.