Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of "add cart rule" action #14707

Merged
merged 16 commits into from Sep 3, 2019

Conversation

@rokaszygmantas
Copy link
Contributor

commented Jul 17, 2019

Questions Answers
Branch? develop
Description? Migrates the logic of adding new cart rule. UI is not migrated, only CQRS command. Covered with unit and behat tests.
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? A small part of this ticket: #10547
How to test? Travis should pass, nothing for QA.

This change is Reviewable

@rokaszygmantas rokaszygmantas changed the title [WIP] Migration of "add cart rule" action Migration of "add cart rule" action Jul 24, 2019
@rokaszygmantas rokaszygmantas marked this pull request as ready for review Jul 24, 2019
@rokaszygmantas rokaszygmantas requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 24, 2019
/**
* @return DiscountApplicationType|null
*/
public function getDiscountApplicationType(): ?DiscountApplicationType

This comment has been minimized.

Copy link
@sarjon

sarjon Jul 24, 2019

Member

Can this be null?

This comment has been minimized.

Copy link
@rokaszygmantas

rokaszygmantas Jul 25, 2019

Author Contributor

yes, it's applicable only when cart rule has percentage or amount discount. In case of gift product or free shipping cart rules - this is null.

@matks matks added the migration label Aug 26, 2019
int $minimumAmountCurrencyId,
bool $isMinimumAmountTaxExcluded,
bool $isMinimumAmountShippingExcluded
) {

This comment has been minimized.

Copy link
@matks

matks Sep 2, 2019

Contributor

This is one big Command 😄

@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

@rokaszygmantas Sorry for the very late review, but the good news is thanks to @sarjon review I find no issue in this PR !

If you rebase it, we can merge it 😉

@rokaszygmantas rokaszygmantas force-pushed the rokaszygmantas:migration/cart_rule_cqrs branch from 3b9b931 to c796817 Sep 2, 2019
@rokaszygmantas

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@matks rebased, just need to wait for build 🙂

@rokaszygmantas rokaszygmantas force-pushed the rokaszygmantas:migration/cart_rule_cqrs branch from c796817 to 30ecde0 Sep 3, 2019
@rokaszygmantas

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

@matks had to rebase once again - feel free to reapprove and merge 🙂

@matks
matks approved these changes Sep 3, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Thank you @rokaszygmantas

@matks matks added this to the 1.7.7.0 milestone Sep 3, 2019
@matks matks merged commit 338dea0 into PrestaShop:develop Sep 3, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rokaszygmantas rokaszygmantas deleted the rokaszygmantas:migration/cart_rule_cqrs branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.