Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make last breadcrumb element not clickable #14710

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

commented Jul 17, 2019

Questions Answers
Branch? develop
Description? Make breadcrumb's last element not clickable, for SEO purpose
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13083
How to test? Go to any page having a breadcrumb in front office (category, product, etc), and check that the last breadcrumb element is not clickable

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 17, 2019

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@colinegin @marionf

Removing the link on the last breadcrumb element changes its style, making it gray:
Capture d’écran 2019-07-17 à 15 14 26

I think it is a good thing, because it follows the default style of our template, and it visually indicates that the element is not clickable.

But if you want the last element to be black, like other elements, tell me so and I will make the change.

@PierreRambaud PierreRambaud changed the title improvement: make last breadcrumb element not clickable Make last breadcrumb element not clickable Jul 17, 2019

@marionf

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

@matthieu-rolland
It's ok for us, but we will wait until next tuesday to have the opinion of @TristanLDD

@TristanLDD

This comment has been minimized.

Copy link

commented Jul 25, 2019

Hi @matthieu-rolland,
I approve the grey color for unclickable item, thanks! :)

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 31, 2019

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 31, 2019

@PierreRambaud PierreRambaud merged commit a2c518a into PrestaShop:develop Jul 31, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@MathiasReker

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

According to official google docs, there should be a link on the last page: https://developers.google.com/search/docs/data-types/breadcrumb

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Hello @marionf, the link that @MathiasReker is sharing with us seems to contradict this pull request, I'm not sure what to do with this information, so I'm pinging you just in case :D

@colinegin

@marionf

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Thank you @matthieu-rolland
I will see it with @colinegin when she will be back !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.