Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Decimal library to 1.2.0 #14711

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@eternoendless
Copy link
Member

commented Jul 17, 2019

Questions Answers
Branch? 1.7.6.x
Description? Update Decimal library to 1.2.0 to avoid errors when using it with numbers expressed in scientific notation
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14694
How to test?

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.6.1 milestone Jul 17, 2019

@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 17, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Can you update the composer.json too?

@PierreRambaud
Copy link
Contributor

left a comment

Update composer.json too

@jolelievre

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Update composer.json too

Why update the composer.json? "prestashop/decimal": "^1.0.0" allows for the 1.2.0 update

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

If you don't update composer.json, this mean your app is working weel without the 1.2.0 and have the same behavior with 1.1.0.

@jolelievre

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

If you don't update composer.json, this mean your app is working weel without the 1.2.0 and have the same behavior with 1.1.0.

Oh so you mean we should update the minimum required version then? "prestashop/decimal": "^1.2.0" ? That makes sens

@jolelievre
Copy link
Contributor

left a comment

Update minimum version "prestashop/decimal": "^1.2.0"

@matks

matks approved these changes Jul 19, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 30, 2019

@PierreRambaud PierreRambaud merged commit e386471 into PrestaShop:1.7.6.x Jul 30, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.