Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile id {render} override issue on theme #14727

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@202-ecommerce
Copy link
Contributor

commented Jul 18, 2019

Questions Answers
Branch? develop
Description? In case of multishop with multiple active theme theme, the smarty tag: {render file='module:mymodule/views/templates/front/_partials/form.tpl' ui=$form} is not compile properly. It's the same bug in an other case than #9763 and in fact partially fixed by #13804
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9763
How to test? You need to have multishop and a different theme activated. you need include a sub template from a module with the {render} smarty tag. The option on backoffice is set to "never recompile templates". You'll see that you will show only one version of the compiled template.

This change is Reviewable

Bug fix in case of multishop / multitheme
@202-ecommerce 202-ecommerce requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 18, 2019
@PierreRambaud PierreRambaud added Bug fix and removed Bug Fix bug labels Jul 18, 2019
@Florian-lg

This comment has been minimized.

Copy link

commented Aug 8, 2019

How to reproduce

Here's a .zip which contains the theme folders with needed themes. You should extract it at the root of your project.

First part

  1. Create a multistore with 2 stores.
  2. The first store will use the "Classic" theme and the second a child theme from the "Classic".

Second part

  1. Go on the login form with the two stores.
  2. The option Template compilation should be on force compilation, and you'll need to clear all caches.
  3. Now, turn the option Template compilation on Never recompile template files and clear all caches, again.
  4. Go on two different login form and you'll see the content of the first compiled template on both stores.
@clotaire202

This comment has been minimized.

Copy link

commented Aug 8, 2019

I hope this zip will be helpfull to reproduce and confirm the fix of the bug.
#QAValidation

@sarahdib sarahdib self-assigned this Aug 20, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Aug 20, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 20, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Thank you @clotaire202 @Florian-lg @202-ecommerce !

@matks matks merged commit 80c47c4 into PrestaShop:develop Aug 20, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks matks changed the title Fix compile id {render} overide on theme Fix compile id {render} override issue on theme Aug 20, 2019
@prestonBot prestonBot added the Bug label Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.