Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Composer.lock file in release #14739

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@jolelievre
Copy link
Contributor

commented Jul 18, 2019

Questions Answers
Branch? 1.7.6.x
Description? Composer.lock file must be kept in the release to avoid warning from Symfony requirements
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? This recommended message about composer must'nt be displayed
image

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.6.1 milestone Jul 18, 2019

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 18, 2019

@jolelievre jolelievre added this to In progress in PrestaShop 1.7.6 via automation Jul 18, 2019

@jolelievre jolelievre moved this from In progress to To be reviewed in PrestaShop 1.7.6 Jul 18, 2019

@jolelievre jolelievre self-assigned this Jul 18, 2019

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

I'm not sure this is right. Actually I wish we could keep both composer.json and composer.lock in zip file to help prestashop developers use Composer on prestashop.

But adding the file to hide the warning seems like a trick to me. Isn't the issue more "why does SF checks that" ?

Actually Symfony uses the composer.lock to detect which Symfony version is used, and then know which PHP min version it needs... not that good.
We could remove or adapt this check from symfonyRequirements.php, we're not supposed to do that (it's explained in the file) because it is updated when we update Symfony (which doesn't occur that often)

@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Jul 18, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 19, 2019

@sarahdib sarahdib moved this from To be tested to To be merged in PrestaShop 1.7.6 Jul 19, 2019

@jolelievre jolelievre merged commit fc398f7 into PrestaShop:1.7.6.x Jul 23, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

PrestaShop 1.7.6 automation moved this from To be merged to Done Jul 23, 2019

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

Thanks @PierreRambaud @sarahdib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.