Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install prestashop test with puppeteer #14764

Merged
merged 21 commits into from Jul 22, 2019

Conversation

@boubkerbribri
Copy link
Contributor

commented Jul 19, 2019

Questions Answers
Branch? develop
Description? Create Install shop test with puppeteer
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? URL_FO=Your_Shop_URL TEST_PATH="smoke/installShop" npm run specific-test

This change is Reviewable

@boubkerbribri boubkerbribri added the WIP label Jul 19, 2019

@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 19, 2019

@boubkerbribri boubkerbribri requested review from SimonGrn and mbadrani Jul 19, 2019

@SimonGrn
Copy link
Contributor

left a comment

Thanks !

Show resolved Hide resolved tests/puppeteer/pages/Install/install.js Outdated
Show resolved Hide resolved tests/puppeteer/pages/Install/install.js Outdated
Show resolved Hide resolved tests/puppeteer/pages/Install/install.js
Show resolved Hide resolved tests/puppeteer/pages/Install/install.js
Show resolved Hide resolved tests/puppeteer/test/smoke/installShop.js Outdated
Show resolved Hide resolved tests/puppeteer/test/utils/globals.js Outdated
@SimonGrn
Copy link
Contributor

left a comment

Thanks

Show resolved Hide resolved tests/puppeteer/README.md Outdated
Show resolved Hide resolved tests/puppeteer/docker-compose.yml Outdated
Show resolved Hide resolved tests/puppeteer/pages/Install/install.js Outdated
Show resolved Hide resolved tests/puppeteer/pages/Install/install.js Outdated

boubkerbribri added some commits Jul 22, 2019

@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Jul 22, 2019

@boubkerbribri boubkerbribri added TE and removed WIP labels Jul 22, 2019

@SimonGrn
Copy link
Contributor

left a comment

@matthieu-rolland
Copy link
Contributor

left a comment

LGTM

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

thanx !

@matthieu-rolland matthieu-rolland merged commit c89d463 into PrestaShop:develop Jul 22, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@boubkerbribri boubkerbribri deleted the boubkerbribri:smokeInstall branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.