Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modifying email body contents #14809

Merged
merged 9 commits into from Oct 30, 2019

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Jul 22, 2019

Questions Answers
Branch? develop
Description? Add translation provider to allow modifying body contents, add a form in Email Theme page to access this edition
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15474
How to test? Go to Design > Email Theme page in the "Translate Emails" page select a language and start editing some texts. Check that the modifications are update in the mails previews, then re-generate emails and tests the modifications in real condition.

This change is Reviewable

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 22, 2019
@jolelievre jolelievre added this to the 1.7.6.1 milestone Jul 22, 2019
@jolelievre jolelievre added this to In progress in PrestaShop 1.7.6 via automation Jul 22, 2019
@jolelievre jolelievre changed the title Add translation provider to allow modifying body contents, add a form… Allow modifying email body contents Jul 22, 2019
Copy link
Contributor

PierreRambaud left a comment

Just a question about _controller param

@jolelievre jolelievre moved this from In progress to To be tested in PrestaShop 1.7.6 Jul 30, 2019
@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Jul 30, 2019

@jolelievre

I change a translation
image

But it didn't change :
In modern theme
image

In classic theme
image

@marionf marionf moved this from To be tested to In progress in PrestaShop 1.7.6 Aug 2, 2019
@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Aug 7, 2019

@sarahdib this problem might be related to #14966

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Aug 8, 2019

I think so too, I'm waiting for this PR on Translator, as well as the one about missing keys #14719 to be merged to test the full feature

@matks matks force-pushed the jolelievre:translate-mails-body branch from f9341ee to f51cf1c Aug 13, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Aug 13, 2019

#14719 has been merged so I have rebased this PR

@jolelievre jolelievre force-pushed the jolelievre:translate-mails-body branch from 8242fd8 to 91a7701 Oct 8, 2019
@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Oct 8, 2019

@Progi1984 it's alright the routes have been renamed, I also removed the starting _ as I discovered recently that these routes are not secured...

Copy link
Contributor Author

jolelievre left a comment

Reviewable status: 0 of 12 files reviewed, 9 unresolved discussions (waiting on @LouiseBonnard, @PierreRambaud, and @Progi1984)


src/PrestaShopBundle/Resources/config/routing/admin/improve/design/mail_theme.yml, line 2 at r5 (raw file):

Previously, Progi1984 (Progi1984) wrote…

lol I prefer because aliases doesn't sound deprecated.

Done.

@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Oct 10, 2019

Reviewable status: 0 of 12 files reviewed, 9 unresolved discussions (waiting on @LouiseBonnard, @PierreRambaud, and @Progi1984)

src/PrestaShopBundle/Resources/config/routing/admin/improve/design/mail_theme.yml, line 2 at r5 (raw file):
Previously, Progi1984 (Progi1984) wrote…

Done.

Ever validated ;)

@jolelievre jolelievre force-pushed the jolelievre:translate-mails-body branch from 91a7701 to 00e09bd Oct 14, 2019
@sarahdib sarahdib self-assigned this Oct 30, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 30, 2019
@eternoendless eternoendless dismissed their stale review Oct 30, 2019

Rebased as requested

@Progi1984 Progi1984 merged commit de7a999 into PrestaShop:develop Oct 30, 2019
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable 12 files, 9 discussions left (LouiseBonnard, PierreRambaud, Progi1984, sarahdib)
Details
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.