Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor problems on the "crawling BO" smoke test #14825

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@SimonGrn
Copy link
Contributor

commented Jul 23, 2019

Questions Answers
Branch? develop
Description? Fix some minor problems on the "crawling BO" smoke test
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
How to test? TEST_PATH=smoke/crawlingBO URL_BO=URL_BO_PS npm run specific-test

This change is Reviewable

fix merge suggestions
change default value for HEADLESS mode

@SimonGrn SimonGrn added TE WIP labels Jul 23, 2019

@SimonGrn SimonGrn added this to the 1.7.7.0 milestone Jul 23, 2019

@SimonGrn SimonGrn requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 23, 2019

@SimonGrn SimonGrn added this to In progress in PrestaShop 1.7.6 via automation Jul 23, 2019

@boubkerbribri
Copy link
Contributor

left a comment

All good thanks

@boubkerbribri boubkerbribri removed the WIP label Jul 23, 2019

@boubkerbribri boubkerbribri removed this from In progress in PrestaShop 1.7.6 Jul 23, 2019

@matthieu-rolland
Copy link
Contributor

left a comment

LGTM

@matthieu-rolland matthieu-rolland merged commit e02ac5f into PrestaShop:develop Jul 23, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.