Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update invalid characters in Customer Creation & Update error messages and tips #14838

Merged
merged 13 commits into from Aug 30, 2019

Conversation

@Progi1984
Copy link
Contributor

commented Jul 24, 2019

Questions Answers
Branch? develop
Description? Update invalid characters in Customer Creation & Update error messages and tips
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14157
How to test? * In BO, create a new customer
* Fill first/last name with an invalid character (@ for example)
* The error message must be displayed under the element and not in top of the form

* In FO, register
* Fill first/last name with an invalid character (@ for example)
* The error message must be updated

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Jul 24, 2019
classes/Validate.php Outdated Show resolved Hide resolved
Copy link
Contributor

left a comment

See comments

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Hi @Progi1984,

When I try to navigate to the FO
I have this error
image

In the branch 1.7.6.x => OK
https://drive.google.com/file/d/1KUGbm9xktvL-xdjje4f6B0F50hlqv7pW/view

Thanks!

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@khouloudbelguith I just test in local and I haven't got the problem. Have you cleaned your cache ?

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Hi @Progi1984,

Yes, it is a cache issue.
In the BO => ok
But in the FO => I have these errors
image

Thanks!

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@khouloudbelguith It's normal, you need to have a space after your dot character.
image

classes/Tools.php Outdated Show resolved Hide resolved
@Progi1984 Progi1984 requested a review from PierreRambaud Aug 30, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Aug 30, 2019
@sarahdib sarahdib self-assigned this Aug 30, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 30, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Thank you @Progi1984

@matks matks merged commit bb8a5dd into PrestaShop:develop Aug 30, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Progi1984 Progi1984 deleted the Progi1984:issue14157 branch Sep 6, 2019
@thbl

This comment has been minimized.

Copy link

commented Sep 11, 2019

Is it possible to add this fix in 1.7.6.1 manually some how ?
as this is a big issue for us

@thbl

This comment has been minimized.

Copy link

commented Sep 11, 2019

also should "/" not be a valid character ?
it was valid before in our case we have a lot of customers using this

@samuel-pires

This comment has been minimized.

Copy link

commented Sep 11, 2019

Hi @thbl,
I would recommend waiting for the 1.7.7 to be released to get this update on your shop.
Until then you can see our recommendations on how to limit spamming attacks on our tech blog: http://build.prestashop.com/news/fighting-against-spamming-again/

About the "/" character, in which situation is it used by your customers? can you tell me more, please?

@thbl

This comment has been minimized.

Copy link

commented Sep 11, 2019

@samuel-pires some (many in our case) use their company name as first / last name.
As multiple people use the same account.
In Denmark a lot of companies has "A/S" in their name, this definds the company type and are a part of the name

@samuel-pires

This comment has been minimized.

Copy link

commented Sep 11, 2019

@samuel-pires some (many in our case) use their company name as first / last name.
As multiple people use the same account.
In Denmark a lot of companies has "A/S" in their name, this definds the company type and are a part of the name

Thanks for the feedback @thbl!
Do you have only B2B clients or individuals as well?
Do you use the B2B mode? it adds a "company" field in the customer creation form (see image) which accepts the "/" character.
Capture d’écran 2019-09-11 à 12 41 23

@LouiseBonnard wdyt?

@thbl

This comment has been minimized.

Copy link

commented Sep 11, 2019

@samuel-pires Have both and yes have B2B enable.
I know about the company field but customers tendens to use first / last name any ways.

@thbl

This comment has been minimized.

Copy link

commented Sep 19, 2019

@LouiseBonnard @samuel-pires any plans for this ?

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

Hi @thbl, thanks for the feedback! In my opinion, nothing needs to be changed here: S/A regards the company name and the "/" character is valid for this field. :-)

cc @samuel-pires

@thbl

This comment has been minimized.

Copy link

commented Sep 24, 2019

@LouiseBonnard as said many customers uses first / last name for company name tho there is a field for it. There for "/" should also be allowed in name as it was in 1.7.5

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

@thbl, thanks for your reply. My point was that they are not supposed to do so, it's a misuse... so let's offer them the chance to use the right field!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.