Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent uninstall of Product Comments module #14863

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@templatin
Copy link
Contributor

commented Jul 26, 2019

Questions Answers
Branch? 1.7.6.x
Description? Product Comments module (v4.0.0) gets uninstalled while upgrading Prestashop.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no

This change is Reviewable

@templatin templatin requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 26, 2019

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Hello @templatin!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Hey, nice job @templatin 😉

@PierreRambaud PierreRambaud added this to the 1.7.6.1 milestone Jul 26, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 29, 2019

@sarahdib sarahdib added this to In progress in PrestaShop 1.7.6 via automation Jul 29, 2019

@PierreRambaud PierreRambaud merged commit 92c0bc4 into PrestaShop:1.7.6.x Jul 29, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

PrestaShop 1.7.6 automation moved this from In progress to Done Jul 29, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Thanks @templatin

@marionf marionf removed this from Done in PrestaShop 1.7.6 Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.