Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes AdminPreferencesController again #14869

Merged

Conversation

@matks
Copy link
Contributor

commented Jul 26, 2019

Return of PR #13910

Questions Answers
Branch? develop
Description? Remove adminPreferencesControllers again
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Please check nothing related to Shop Preferences page is broken

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 26, 2019
@matks matks added the migration label Jul 26, 2019
Copy link
Contributor

left a comment

View change

Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@matks matks requested a review from PierreRambaud Aug 16, 2019
@sarahdib sarahdib self-assigned this Aug 19, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Aug 19, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 19, 2019
@PierreRambaud PierreRambaud merged commit d3b0eb8 into PrestaShop:develop Aug 19, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Thanks @matks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.