Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy images from SCSS directory to public for the new-theme (for improving the production ZIP) #14925

Merged
merged 3 commits into from Sep 12, 2019

Conversation

@Progi1984
Copy link
Contributor

commented Jul 31, 2019

Questions Answers
Branch? develop
Description? When building the ZIP production, some images called to SCSS directory from the them
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14757
How to test? After building the ZIP (php tools/build/CreateRelease.php), images doesn't have to be called in SCSS directory

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 31, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jul 31, 2019
@PierreRambaud PierreRambaud dismissed their stale review Jul 31, 2019

Currently in discussion about this fix :D

@Progi1984 Progi1984 requested review from PrestaShop/prestashop-core-developers and PierreRambaud Jul 31, 2019
@Progi1984 Progi1984 changed the title Copy images from SCSS directory to public for the new-theme (for improving the production ZIP Copy images from SCSS directory to public for the new-theme (for improving the production ZIP) Aug 26, 2019
@PierreRambaud PierreRambaud force-pushed the Progi1984:issue14757 branch from d3bbf15 to 742a385 Aug 29, 2019
@eternoendless

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

Needs a rebase

@PierreRambaud PierreRambaud self-assigned this Sep 4, 2019
@PierreRambaud PierreRambaud dismissed stale reviews from eternoendless and jolelievre via 22d9b4c Sep 6, 2019
@PierreRambaud PierreRambaud force-pushed the Progi1984:issue14757 branch from 742a385 to 22d9b4c Sep 6, 2019
@Progi1984 Progi1984 requested a review from jolelievre Sep 6, 2019
Copy link
Contributor

left a comment

Thanks @PierreRambaud @Progi1984

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 12, 2019
@matks matks merged commit 4578130 into PrestaShop:develop Sep 12, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Progi1984 Progi1984 deleted the Progi1984:issue14757 branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.