Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs filtering #14926

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@sarjon
Copy link
Member

commented Jul 31, 2019

Questions Answers
Branch? 1.7.6.x
Description? Fixes log filtering by setting query parameters separately since using setPramaters() resets all previously set parameters into query builder.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #14785
How to test? See ticket for how to test.

This change is Reviewable

@sarjon sarjon requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 31, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.1 milestone Jul 31, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 31, 2019

@PierreRambaud PierreRambaud merged commit 210a78f into PrestaShop:1.7.6.x Jul 31, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Thanks @sarjon

@sarjon sarjon deleted the sarjon:fix-logs-filtering branch Jul 31, 2019

This was referenced Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.