Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic Theme : Plugin EmailSubscription : override the template for column #14937

Merged
merged 5 commits into from Aug 29, 2019

Conversation

@Progi1984
Copy link
Contributor

commented Jul 31, 2019

Questions Answers
Branch? develop
Description? Thanks to PrestaShop/ps_emailsubscription#37, that fixes the bug when a Newsletter plugin is added in the hook "displayLeftColumn"
Type? bug fix
Category? FO
BC breaks? yes
Deprecations? yes
Fixed ticket? Fixes #9907
How to test? * Add a plugin Newsletter in the top of the displayLeftColumn hook
* The display must be good in the frontoffice

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 31, 2019
@sarahdib sarahdib added the FO label Jul 31, 2019
@Progi1984 Progi1984 requested a review from PierreRambaud Aug 1, 2019
@Progi1984 Progi1984 force-pushed the Progi1984:issue9907_new branch from d311408 to 9367c2a Aug 29, 2019
@Progi1984 Progi1984 requested a review from PierreRambaud Aug 29, 2019
@PierreRambaud PierreRambaud merged commit f6ea677 into PrestaShop:develop Aug 29, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Thanks @Progi1984

@Progi1984 Progi1984 deleted the Progi1984:issue9907_new branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.