Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when loading theme that includes a translations directory but no translations #14938

Merged

Conversation

@eternoendless
Copy link
Member

commented Jul 31, 2019

Questions Answers
Branch? 1.7.6.x
Description? When loading a theme, ThemeManager will try to load its translations if the translations directory is present. But if it's present AND empty it would throw an exception.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? Yes, TranslationFinderTrait has been extracted into a class of its own, TranslationFinder.
Fixed ticket? Fixes #14960
How to test? Create a theme that is not named classic, make sure there's a translations directory in it with nothing inside. Zip it and try to import it into PS.

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.6.1 milestone Jul 31, 2019
@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 31, 2019
@eternoendless eternoendless added this to In progress in PrestaShop 1.7.6 via automation Jul 31, 2019
@eternoendless eternoendless moved this from In progress to To be reviewed in PrestaShop 1.7.6 Jul 31, 2019
@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Done!

Copy link
Contributor

left a comment

LGTM !

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Hi @eternoendless,

It is OK.
checked with this theme
childtheme-example.zip

Thanks!

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Thanks everyone!

@eternoendless eternoendless merged commit 80bb724 into PrestaShop:1.7.6.x Aug 7, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eternoendless eternoendless deleted the eternoendless:fix-error-when-loading-theme branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.