Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed {firstname} typo in order customer comment mail in 1.7.6.x #14945

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@dheerajwebkul
Copy link
Contributor

commented Aug 1, 2019

Questions Answers
Branch? 1.7.6.x
Description? Please be specific when describing the PR.
Every detail helps: versions, browser/server configuration, specific module/theme, etc.
Type? bug fix
Category? FO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? #14906
How to test? Just got to FO order details page and send a message to admin for the order. Admin can see this error in the mail.

This change is Reviewable

dheerajwebkul added some commits Aug 1, 2019

Merge pull request #2 from dheerajwebkul/customer-message-mail-typo
Fixed {firstname} typo in order customer comment mail

@dheerajwebkul dheerajwebkul requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 1, 2019

@marionf marionf added 1.7.6.x and removed develop labels Aug 1, 2019

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Hi @dheerajwebkul,

It is OK
image

Thanks!

@khouloudbelguith khouloudbelguith added this to In progress in PrestaShop 1.7.6 via automation Aug 1, 2019

@khouloudbelguith khouloudbelguith removed this from In progress in PrestaShop 1.7.6 Aug 1, 2019

@khouloudbelguith khouloudbelguith added this to the 1.7.6.1 milestone Aug 1, 2019

@jolelievre jolelievre merged commit 712c96a into PrestaShop:1.7.6.x Aug 1, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.