Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Module.php docs on version property type #14949

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@zalexki
Copy link
Contributor

commented Aug 1, 2019

Questions Answers
Branch? develop
Description? Wrong php doc type
Type? improvement
Category? ??
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? use phpstan lvl 5

This change is Reviewable

@zalexki zalexki requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 1, 2019

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Hello @zalexki!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Hi!

Your pull request description seems to be incomplete or malformed:

  • The description shouldn't be empty.
  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Hi,
Your PR is incomplete, you need to implement the contribution table.

Regards,

@zalexki

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@PierreRambaud i know i know, im just lazy.
done.

@matthieu-rolland
Copy link
Contributor

left a comment

LGTM

@matthieu-rolland matthieu-rolland merged commit 562a8cc into PrestaShop:develop Aug 1, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zalexki zalexki deleted the zalexki:patch-1 branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.