Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PrestaShopCollection.php docs on getFirst method return type #14951

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@zalexki
Copy link
Contributor

commented Aug 1, 2019

Questions Answers
Branch? develop
Description? Wrong php doc type
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? use phpstan lvl 5

This change is Reviewable

@zalexki zalexki requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 1, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Hello @zalexki!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Aug 19, 2019
@PierreRambaud PierreRambaud merged commit 1412574 into PrestaShop:develop Aug 19, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Thanks @zalexki

@zalexki zalexki deleted the zalexki:patch-2 branch Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.