Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate prices feature #14959

Merged
merged 5 commits into from Aug 26, 2019

Conversation

@202-ecommerce
Copy link
Contributor

commented Aug 1, 2019

Questions Answers
Branch? develop
Description? add the duplication of a product price in multishop when the product has a different price in each shops
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14958 .
How to test? Steps to reproduce the behavior:

Set a multishop with 2 shops (or more). For instance:
Create a product in context all shop
On each shop set a different price for the product
Finally on products board, select the previous product and click on duplicate product on all shop context.


This change is Reviewable

@202-ecommerce 202-ecommerce requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 1, 2019
Copy link
Contributor

left a comment

Thank you for this PR, I made a minor comment, could you check it out?

@@ -4468,6 +4468,27 @@ public static function duplicateTaxes($id_product_old, $id_product_new)
return true;
}
public static function duplicatePrices($id_product_old, $id_product_new)

This comment has been minimized.

Copy link
@matthieu-rolland

matthieu-rolland Aug 1, 2019

Contributor

Hello, thanx a lot for your contribution !

Could you please add a proper phpdoc including a short description of the method ?

@202-ecommerce

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Hi @matthieu-rolland ,
I just added the PHPDoc as you asked and validated the PrettyCI

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

thanx @202-ecommerce ! your fix will be tested by the QA before we can merge it.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Hi @202-ecommerce,

The Price per unit (tax excl.) is not duplicated, if we duplicate a product, it remains to 0.
image
Thanks!

@202-ecommerce

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Hi @khouloudbelguith ,
Just made the fix for the Price per unit

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@202-ecommerce, thanks!
Waiting for a review.

Copy link
Contributor

left a comment

LGTM

@PierreRambaud PierreRambaud changed the title PrestaShop#14958 : add duplicate prices Add duplicate prices feature Aug 21, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 21, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Aug 21, 2019
@matthieu-rolland matthieu-rolland merged commit fbe37cb into PrestaShop:develop Aug 26, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.