Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Keep BO from using two different translators in parallel #14966
His PR renames translation test modules, allows underscores in translation domain name, and adds useful comments to understand the two translators.
From there, this PR adds a few things, the main goal being that wether we are in FO or BO, we always use only one translator, either the translator component or the one from frameworkbundle. Also make it so that we still have the translation part in symfony's debug toolbar, and that the database translations are still working in modules.
I carefully checked that the component translator is never called in back office, and that the framework bundle translator is never called in front office.
I removed the part where I changed the place where the container was called for the first time, in
The reason is that it creates a bug, only on PHP 5.6 when opcache is disabled.
I know, it's weird, it looks a lot like this bug:
Why only in php 5.6? I dont know...
I tried with different modules for example